Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

Aligns BackendConfigurationFiles page object with the pattern established in BackendConfigurationProperties (line 299), switching from DOM traversal to direct indexed ID selectors for element fetching.

HTML Template Changes:

  • Added indexed ID templates: fileId-{{i}}, fileCreateDate-{{i}}, fileName-{{i}}, editTagsBtn-{{i}}
  • Added let-i="index" to templates requiring row indexing

Page Object Refactoring:

  • Replaced DOM traversal with direct ID selectors matching reference pattern:
    // Before: await this.row.$('.mat-column-id span')
    // After:  await (await $('#fileId-'+rowNum)).getText()
  • Updated button selectors: $('#editTagsBtn-'+rowNum), $('#viewPdfBtn-'+rowNum), etc.
  • Removed unused row and checkbox fields from FileRowObject
  • Retained row-based querying for dynamic arrays (properties/tags)
Original prompt

This section details on the original issue you should resolve

<issue_title>fix wdio page objects to fecth the dom elements the same way</issue_title>
<issue_description>Use https://github.com/microting/eform-backendconfiguration-plugin/blob/master/eform-client/e2e/Page%20objects/BackendConfiguration/BackendConfigurationProperties.page.ts#L299 as reference to implement the same style in these Page Obejcts:

eform-client/e2e/Page objects/BackendConfiguration/BackendConfigurationFiles.page.ts</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix WDIO page objects to fetch DOM elements consistently Refactor BackendConfigurationFiles page object to use indexed ID selectors Nov 6, 2025
Copilot AI requested a review from renemadsen November 6, 2025 12:04
Copilot finished work on behalf of renemadsen November 6, 2025 12:04
@renemadsen renemadsen marked this pull request as ready for review November 6, 2025 13:19
@renemadsen renemadsen merged commit 7cce22a into master Nov 6, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix wdio page objects to fecth the dom elements the same way

2 participants